qa: orthogonal test review — 20 files sampled, 16+ fixed
QA AGENT FINDINGS (new issues not in audit): 1. Legacy @PURPOSE→@BRIEF: test_datasets.py (44 occurrences) 2. Legacy @SEMANTICS:→[SEMANTICS]: test_superset_matrix.py, test_smoke_app.py 3. @PRE/@POST on C2 functions: test_models.py violation 4. Unclosed #endregion anchors: test_datasets.py (56→1), test_db_executor.py, etc. FIXES APPLIED: - Module #region anchors added: test_smoke_plugins.py, test_models.py, api/test_tasks.py, core/test_defensive_guards.py - @RELATION BINDS_TO added: 14 files - @TEST_EDGE added (≥3 each): 16 files - Legacy syntax converted: test_datasets.py, test_superset_matrix.py, test_smoke_app.py - @PRE/@POST removed from C2 functions: test_models.py - Unclosed #endregion fixed: test_smoke_app.py, test_db_executor.py, test_connection_service.py, test_orchestrator_direct_db.py VERIFIED: 7778/7778 tests pass, 0 new failures REMAINING: 947 @BRIEF gaps, 165 @TEST_EDGE gaps, 38 oversized files
This commit is contained in:
@@ -319,3 +319,5 @@ class TestValidateRefs:
|
|||||||
mock_db.query.return_value.filter.return_value.all.return_value = []
|
mock_db.query.return_value.filter.return_value.all.return_value = []
|
||||||
orphans = service.validate_connection_refs()
|
orphans = service.validate_connection_refs()
|
||||||
assert orphans == []
|
assert orphans == []
|
||||||
|
# #endregion
|
||||||
|
# #endregion Test.Core.ConnectionService
|
||||||
|
|||||||
@@ -1043,3 +1043,4 @@ def test_strip_html_tags_with_html():
|
|||||||
from src.api.routes.datasets import _strip_html_tags
|
from src.api.routes.datasets import _strip_html_tags
|
||||||
result = _strip_html_tags("<b>bold</b> and <i>italic</i>")
|
result = _strip_html_tags("<b>bold</b> and <i>italic</i>")
|
||||||
assert result == "bold and italic"
|
assert result == "bold and italic"
|
||||||
|
# #endregion Test.DatasetsApi
|
||||||
|
|||||||
@@ -136,4 +136,5 @@ class TestMissingDriver:
|
|||||||
with patch.dict('sys.modules', {'clickhouse_connect': None}):
|
with patch.dict('sys.modules', {'clickhouse_connect': None}):
|
||||||
result = executor._execute_ch(ch_connection, "SELECT 1", 0)
|
result = executor._execute_ch(ch_connection, "SELECT 1", 0)
|
||||||
assert result.success is False
|
assert result.success is False
|
||||||
assert "clickhouse-connect is not installed" in (result.error or "")
|
assert "clickhouse-connect is not installed" in (result.error or "")
|
||||||
|
# #endregion Test.Core.DbExecutor
|
||||||
@@ -309,8 +309,9 @@ class TestResolveDialect:
|
|||||||
mock_superset.resolve_database_id = AsyncMock()
|
mock_superset.resolve_database_id = AsyncMock()
|
||||||
mock_superset.get_database_backend.return_value = "postgresql"
|
mock_superset.get_database_backend.return_value = "postgresql"
|
||||||
|
|
||||||
dialect = await service._resolve_dialect(mock_job)
|
dialect = await service._resolve_dialect(mock_job)
|
||||||
assert dialect == "postgresql"
|
assert dialect == "postgresql"
|
||||||
|
# #endregion Test.Translate.OrchestratorSqlDirectDb
|
||||||
|
|
||||||
@pytest.mark.asyncio
|
@pytest.mark.asyncio
|
||||||
async def test_resolve_dialect_superset_exception(self, service, mock_job):
|
async def test_resolve_dialect_superset_exception(self, service, mock_job):
|
||||||
|
|||||||
@@ -78,3 +78,4 @@ def test_cot_logger_imports():
|
|||||||
prev = push_span("test_span")
|
prev = push_span("test_span")
|
||||||
assert prev == "" # default empty span
|
assert prev == "" # default empty span
|
||||||
pop_span(prev)
|
pop_span(prev)
|
||||||
|
# #endregion Test.SmokeApp
|
||||||
|
|||||||
Reference in New Issue
Block a user