semantics: complete DEF-to-region migration, fix regressions
- Convert legacy [DEF🆔Type] anchors to #region/#endregion across 329 files
- Reinstate _normalize_timestamp_value in sql_generator.py
- Fix MarkerLogger→logger migration in events.py (molecular CoT markers)
- Fix dataset_review orchestrator dependencies (_build_execution_snapshot)
- Fix config_manager stale-record deletion (moved to save path only)
- Add 77 missing [/DEF:] closers in 5 unbalanced test files
- Update assistant_chat.integration.test.js for #region format
- Apply molecular-cot-logging markers (REASON/REFLECT/EXPLORE) via logger.* methods
This commit is contained in:
@@ -1,11 +1,11 @@
|
||||
# #region AssistantDispatch [C:5] [TYPE Module]
|
||||
# @BRIEF Intent dispatch engine, confirmation summary, and clarification text for the assistant API.
|
||||
# @LAYER API
|
||||
# @INVARIANT Unsupported operations are rejected via HTTPException(400).
|
||||
# @LAYER: API
|
||||
# @RELATION DEPENDS_ON -> [AssistantSchemas]
|
||||
# @RELATION DEPENDS_ON -> [AssistantResolvers]
|
||||
# @RELATION DEPENDS_ON -> [AssistantLlmPlanner]
|
||||
# @RELATION DEPENDS_ON -> [AssistantDatasetReview]
|
||||
# @INVARIANT: Unsupported operations are rejected via HTTPException(400).
|
||||
|
||||
from __future__ import annotations
|
||||
|
||||
@@ -42,8 +42,8 @@ git_service = GitService()
|
||||
|
||||
# #region _clarification_text_for_intent [C:2] [TYPE Function]
|
||||
# @BRIEF Convert technical missing-parameter errors into user-facing clarification prompts.
|
||||
# @PRE state was classified as needs_clarification for current intent/error combination.
|
||||
# @POST Returned text is human-readable and actionable for target operation.
|
||||
# @PRE: state was classified as needs_clarification for current intent/error combination.
|
||||
# @POST: Returned text is human-readable and actionable for target operation.
|
||||
def _clarification_text_for_intent(
|
||||
intent: Optional[Dict[str, Any]], detail_text: str
|
||||
) -> str:
|
||||
@@ -69,9 +69,9 @@ def _clarification_text_for_intent(
|
||||
|
||||
# #region _async_confirmation_summary [C:4] [TYPE Function]
|
||||
# @BRIEF Build human-readable confirmation prompt for an intent before execution.
|
||||
# @PRE actions is a non-empty list of planned review actions.
|
||||
# @POST Returns a formatted summary string suitable for display to the user.
|
||||
# @SIDE_EFFECT None - pure formatting function.
|
||||
# @PRE: actions is a non-empty list of planned review actions.
|
||||
# @POST: Returns a formatted summary string suitable for display to the user.
|
||||
# @SIDE_EFFECT: None - pure formatting function.
|
||||
async def _async_confirmation_summary(intent: Dict[str, Any], config_manager: ConfigManager, db: Session) -> str:
|
||||
with belief_scope('_confirmation_summary'):
|
||||
logger.reason('Belief protocol reasoning checkpoint for _confirmation_summary')
|
||||
@@ -139,15 +139,15 @@ async def _async_confirmation_summary(intent: Dict[str, Any], config_manager: Co
|
||||
|
||||
# #region _dispatch_intent [C:5] [TYPE Function]
|
||||
# @BRIEF Execute parsed assistant intent via existing task/plugin/git services.
|
||||
# @PRE intent operation is known and actor permissions are validated per operation.
|
||||
# @POST Returns response text, optional task id, and UI actions for follow-up.
|
||||
# @SIDE_EFFECT May enqueue tasks, invoke git operations, and query/update external service state.
|
||||
# @DATA_CONTRACT Input[intent,current_user,task_manager,config_manager,db] -> Output[Tuple[text:str,task_id:Optional[str],actions:List[AssistantAction]]]
|
||||
# @INVARIANT unsupported operations are rejected via HTTPException(400).
|
||||
# @DATA_CONTRACT: Input[intent,current_user,task_manager,config_manager,db] -> Output[Tuple[text:str,task_id:Optional[str],actions:List[AssistantAction]]]
|
||||
# @RELATION DEPENDS_ON -> [_check_any_permission]
|
||||
# @RELATION DEPENDS_ON -> [_resolve_dashboard_id_entity]
|
||||
# @RELATION DEPENDS_ON -> [TaskManager]
|
||||
# @RELATION DEPENDS_ON -> [GitService]
|
||||
# @SIDE_EFFECT: May enqueue tasks, invoke git operations, and query/update external service state.
|
||||
# @PRE: intent operation is known and actor permissions are validated per operation.
|
||||
# @POST: Returns response text, optional task id, and UI actions for follow-up.
|
||||
# @INVARIANT: unsupported operations are rejected via HTTPException(400).
|
||||
async def _dispatch_intent(intent: Dict[str, Any], current_user: User, task_manager: TaskManager, config_manager: ConfigManager, db: Session) -> Tuple[str, Optional[str], List[AssistantAction]]:
|
||||
with belief_scope('_dispatch_intent'):
|
||||
logger.reason('Belief protocol reasoning checkpoint for _dispatch_intent')
|
||||
|
||||
Reference in New Issue
Block a user