Password promt

backend/src/plugins/migration.py

@@ -100,7 +100,31 @@ class MigrationPlugin(PluginBase):
         from_db_id = params.get("from_db_id")
         to_db_id = params.get("to_db_id")
         
-        logger = SupersetLogger(log_dir=Path.cwd() / "logs", console=True)
+        # [DEF:MigrationPlugin.execute:Action]
+        # @PURPOSE: Execute the migration logic with proper task logging.
+        task_id = params.get("_task_id")
+        from ..dependencies import get_task_manager
+        tm = get_task_manager()
+
+        class TaskLoggerProxy(SupersetLogger):
+            def __init__(self):
+                # Initialize parent with dummy values since we override methods
+                super().__init__(console=False)
+                
+            def debug(self, msg, *args, extra=None, **kwargs):
+                if task_id: tm._add_log(task_id, "DEBUG", msg, extra or {})
+            def info(self, msg, *args, extra=None, **kwargs):
+                if task_id: tm._add_log(task_id, "INFO", msg, extra or {})
+            def warning(self, msg, *args, extra=None, **kwargs):
+                if task_id: tm._add_log(task_id, "WARNING", msg, extra or {})
+            def error(self, msg, *args, extra=None, **kwargs):
+                if task_id: tm._add_log(task_id, "ERROR", msg, extra or {})
+            def critical(self, msg, *args, extra=None, **kwargs):
+                if task_id: tm._add_log(task_id, "ERROR", msg, extra or {})
+            def exception(self, msg, *args, **kwargs):
+                if task_id: tm._add_log(task_id, "ERROR", msg, {"exception": True})
+
+        logger = TaskLoggerProxy()
         logger.info(f"[MigrationPlugin][Entry] Starting migration task.")
         logger.info(f"[MigrationPlugin][Action] Params: {params}")
 
@@ -188,10 +212,7 @@ class MigrationPlugin(PluginBase):
                             
                             if not success and replace_db_config:
                                 # Signal missing mapping and wait (only if we care about mappings)
-                                task_id = params.get("_task_id")
                                 if task_id:
-                                    from ..dependencies import get_task_manager
-                                    tm = get_task_manager()
                                     logger.info(f"[MigrationPlugin][Action] Pausing for missing mapping in task {task_id}")
                                     # In a real scenario, we'd pass the missing DB info to the frontend
                                     # For this task, we'll just simulate the wait
@@ -220,16 +241,25 @@ class MigrationPlugin(PluginBase):
                 except Exception as exc:
                     # Check for password error
                     error_msg = str(exc)
+                    # The error message from Superset is often a JSON string inside a string.
+                    # We need to robustly detect the password requirement.
+                    # Typical error: "Error importing dashboard: databases/PostgreSQL.yaml: {'_schema': ['Must provide a password for the database']}"
+                    
                     if "Must provide a password for the database" in error_msg:
-                        # Extract database name (assuming format: "Must provide a password for the database 'PostgreSQL'")
+                        # Extract database name
+                        # Try to find "databases/DBNAME.yaml" pattern
                         import re
-                        match = re.search(r"database '([^']+)'", error_msg)
-                        db_name = match.group(1) if match else "unknown"
-                        
-                        # Get task manager
-                        from ..dependencies import get_task_manager
-                        tm = get_task_manager()
-                        task_id = params.get("_task_id")
+                        db_name = "unknown"
+                        match = re.search(r"databases/([^.]+)\.yaml", error_msg)
+                        if match:
+                            db_name = match.group(1)
+                        else:
+                            # Fallback: try to find 'database 'NAME'' pattern
+                             match_alt = re.search(r"database '([^']+)'", error_msg)
+                             if match_alt:
+                                 db_name = match_alt.group(1)
+
+                        logger.warning(f"[MigrationPlugin][Action] Detected missing password for database: {db_name}")
                         
                         if task_id:
                             input_request = {
@@ -251,6 +281,9 @@ class MigrationPlugin(PluginBase):
                                 logger.info(f"[MigrationPlugin][Action] Retrying import for {title} with provided passwords.")
                                 to_c.import_dashboard(file_name=tmp_new_zip, dash_id=dash_id, dash_slug=dash_slug, passwords=passwords)
                                 logger.info(f"[MigrationPlugin][Success] Dashboard {title} imported after password injection.")
+                                # Clear passwords from params after use for security
+                                if "passwords" in task.params:
+                                    del task.params["passwords"]
                                 continue
 
                     logger.error(f"[MigrationPlugin][Failure] Failed to migrate dashboard {title}: {exc}", exc_info=True)