security: critical auth fixes, test migration to SQLite+FK, 44 test fixes

CRITICAL (CVE-class):
- C-4: Remove DEV_MODE fallback with hardcoded postgres:postgres credentials
- C-3: WebSocket endpoints now require JWT or API key token (?token=) auth
- C-1: Superset environment passwords encrypted via Fernet at rest in DB
- H-4: SESSION_SECRET_KEY separated from JWT AUTH_SECRET_KEY
- H-1: Log injection via %s-formatting instead of f-strings
- H-5: X-Trace-ID header validated as UUID4 to prevent trace poisoning

INFRASTRUCTURE:
- New src/core/encryption.py — EncryptionManager extracted from llm_provider
- Test DB: per-module sqlite:///:memory: with PRAGMA foreign_keys=ON
- testcontainers PostgreSQL via TEST_DB=postgres env var
- conftest temp-file global engine (no 10GB shared-cache leak)

TEST FIXES (44 pre-existing → 0):
- test_smoke_plugins: module-level sys.modules mock isolated to per-test fixture
- test_migration_engine: EXT:Python:uuid → uuid syntax fix
- test_dashboards_api: mock env attributes + correct patch target
- test_constants_audit_fixes: sync expected constant names with actual
- test_defensive_guards: patch.object instead of module-level Repo mock
- test_clean_release_cli: removed empty config.json directory
- FK violations: TaskRecord parents in log_persistence, Environment in
  mapping_service, ReleaseCandidate in candidate_manifest_services

ORTHOGONAL TESTS (18 new):
- test_security_orthogonal.py: bcrypt 72-byte limit, unicode, API key
  format invariants, Fernet robustness, encryption key lifecycle,
  log injection protection, JWT edge cases

MODEL FIXES:
- MetricSnapshot.job_id: nullable with SET NULL (was broken FK for
  aggregate prune snapshots, hidden by SQLite)

CLEANUP:
- Removed stale :memory:test_main/test_auth/test_tasks file databases
- Removed duplicate #endregion in encryption_key.py
This commit is contained in:
2026-05-26 14:58:49 +03:00
parent 10adce2e1f
commit bb03929ca1
29 changed files with 928 additions and 176 deletions

View File

@@ -9,7 +9,7 @@ from datetime import UTC, datetime
from pathlib import Path
import pytest
from sqlalchemy import create_engine
from sqlalchemy import create_engine, event
from sqlalchemy.orm import sessionmaker
# Add backend directory to sys.path so 'src' can be resolved
@@ -18,16 +18,26 @@ if backend_dir not in sys.path:
sys.path.insert(0, backend_dir)
from src.core.mapping_service import IdMappingService
from src.models.mapping import Base, ResourceMapping, ResourceType
from src.models.mapping import Base, Environment, ResourceMapping, ResourceType
@pytest.fixture
def db_session():
# In-memory SQLite for testing
engine = create_engine("sqlite:///:memory:")
event.listen(engine, "connect", lambda c, _: c.execute("PRAGMA foreign_keys=ON"))
Base.metadata.create_all(engine)
Session = sessionmaker(bind=engine)
session = Session()
# Create FK parent Environment records for all environment_ids used in tests
for env_id in ['test-env', 'prod-env-1', 'env1']:
if not session.query(Environment).filter(Environment.id == env_id).first():
session.add(Environment(
id=env_id, name=env_id,
url=f'http://{env_id}.example.com',
credentials_id=env_id
))
session.commit()
yield session
session.close()