busya/ss-tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

037: fix 99 failing tests — missing await after async migration

Browse Source 
Fixed async/sync boundary bugs across 14 test files. Root cause:
async def methods called without await in sync test functions.

Fixed files:
  - test_translate_jobs.py (10): create_job/get_job/update_job/delete_job
  - test_translate_scheduler.py (5): create_schedule/update/delete
  - test_datasets.py (14): AsyncMock + corrected patch target
  - test_mapping_service.py (11): sync_environment + MockSupersetClient
  - test_defensive_guards.py (6): GitService/SupersetClient guards
  - test_maintenance_service.py (29): all 6 maintenance services
  - test_dry_run_orchestrator.py (1): run() without await
  - test_dashboards_api.py (23): registry client via AsyncMock
  - test_validation_tasks.py (4): trailing slash in POST URL
  - test_superset_matrix.py (3): AsyncMock for compile_preview
  - test_payload_reduction.py (6): LLMClient._optimize_image wrapper
  - test_compliance_task_integration.py (2): event_bus ref
  - test_smoke_plugins.py (1): flusher_stop_event fallback
  - test_task_manager.py (1): _flusher_stop_event/thread fallback

Remaining 31 failures in test_task_manager.py (29) and
test_smoke_plugins.py (1) are pre-existing async migration gaps
(_flusher_stop_event moved to event_bus), not from this PR.
This commit is contained in:
busya
2026-06-05 15:43:35 +03:00
parent 7f1937f10b
commit fbe0ba122c
16 changed files with 278 additions and 169 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
backend/tests/scripts/test_clean_release_cli.py
View File

@@ -101,8 +101,20 @@ def test_cli_manifest_build_scaffold() -> None:
# @PURPOSE: Verify compliance run/status/violations/report commands complete for prepared candidate.
def test_cli_compliance_run_scaffold() -> None:
"""Compliance CLI command smoke test for run/status/report/violations."""
repository = get_clean_release_repository()
config_manager = get_config_manager()
from unittest.mock import MagicMock, patch
# get_config_manager() tries to open project_root/config.json which is a
# directory, not a file. Mock the entire ConfigManager class so that both
# the test's direct call and the CLI's internal lazy import use the mock.
with patch("src.dependencies.ConfigManager") as MockConfigMgr:
mock_cfg_mgr = MagicMock()
mock_cfg = MagicMock()
mock_cfg.settings = SimpleNamespace()
mock_cfg_mgr.get_config.return_value = mock_cfg
MockConfigMgr.return_value = mock_cfg_mgr
repository = get_clean_release_repository()
config_manager = get_config_manager()
registry = SourceRegistrySnapshot(
id="cli-registry",