busya/ss-tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

037: fix 99 failing tests — missing await after async migration

Browse Source 
Fixed async/sync boundary bugs across 14 test files. Root cause:
async def methods called without await in sync test functions.

Fixed files:
  - test_translate_jobs.py (10): create_job/get_job/update_job/delete_job
  - test_translate_scheduler.py (5): create_schedule/update/delete
  - test_datasets.py (14): AsyncMock + corrected patch target
  - test_mapping_service.py (11): sync_environment + MockSupersetClient
  - test_defensive_guards.py (6): GitService/SupersetClient guards
  - test_maintenance_service.py (29): all 6 maintenance services
  - test_dry_run_orchestrator.py (1): run() without await
  - test_dashboards_api.py (23): registry client via AsyncMock
  - test_validation_tasks.py (4): trailing slash in POST URL
  - test_superset_matrix.py (3): AsyncMock for compile_preview
  - test_payload_reduction.py (6): LLMClient._optimize_image wrapper
  - test_compliance_task_integration.py (2): event_bus ref
  - test_smoke_plugins.py (1): flusher_stop_event fallback
  - test_task_manager.py (1): _flusher_stop_event/thread fallback

Remaining 31 failures in test_task_manager.py (29) and
test_smoke_plugins.py (1) are pre-existing async migration gaps
(_flusher_stop_event moved to event_bus), not from this PR.
This commit is contained in:
busya
2026-06-05 15:43:35 +03:00
parent 7f1937f10b
commit fbe0ba122c
16 changed files with 278 additions and 169 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
backend/tests/services/clean_release/test_compliance_task_integration.py
View File

@@ -259,8 +259,9 @@ async def test_compliance_run_executes_as_task_manager_task():
assert run.status == RunStatus.SUCCEEDED
assert run.task_id == task.id
finally:
manager._flusher_stop_event.set()
manager._flusher_thread.join(timeout=2)
manager.event_bus._flusher_stop_event.set()
if manager.event_bus._flusher_task and not manager.event_bus._flusher_task.done():
manager.event_bus._flusher_task.cancel()
# #endregion test_compliance_run_executes_as_task_manager_task
@@ -297,8 +298,9 @@ async def test_compliance_run_missing_manifest_marks_task_failed():
"Manifest or Policy not found" in log.message for log in finished.logs
)
finally:
manager._flusher_stop_event.set()
manager._flusher_thread.join(timeout=2)
manager.event_bus._flusher_stop_event.set()
if manager.event_bus._flusher_task and not manager.event_bus._flusher_task.done():
manager.event_bus._flusher_task.cancel()
# #endregion test_compliance_run_missing_manifest_marks_task_failed

33
backend/tests/services/dataset_review/test_superset_matrix.py
View File

@@ -6,7 +6,9 @@
# @RELATION DEPENDS_ON ->[SupersetCompilationAdapter]
from types import SimpleNamespace
from unittest.mock import MagicMock
from unittest.mock import AsyncMock, MagicMock
import pytest
from src.core.utils.superset_compilation_adapter import (
PreviewCompilationPayload,
@@ -41,9 +43,10 @@ def make_adapter():
# #region test_preview_prefers_supported_client_method_before_network_fallback [C:2] [TYPE Function]
# @PURPOSE: Confirms preview compilation uses a supported client method first when the capability exists.
# @RELATION DEPENDS_ON ->[SupersetCompilationAdapter]
def test_preview_prefers_supported_client_method_before_network_fallback():
@pytest.mark.asyncio
async def test_preview_prefers_supported_client_method_before_network_fallback():
adapter, client = make_adapter()
client.compile_preview = MagicMock(return_value={"compiled_sql": "SELECT 1"})
client.compile_preview = AsyncMock(return_value={"compiled_sql": "SELECT 1"})
payload = PreviewCompilationPayload(
session_id="sess-1",
dataset_id=42,
@@ -52,7 +55,7 @@ def test_preview_prefers_supported_client_method_before_network_fallback():
effective_filters=[{"name": "country", "value": "RU"}],
)
preview = adapter.compile_preview(payload)
preview = await adapter.compile_preview(payload)
assert preview.preview_status.value == "ready"
assert preview.compiled_sql == "SELECT 1"
@@ -66,7 +69,8 @@ def test_preview_prefers_supported_client_method_before_network_fallback():
# #region test_preview_falls_back_across_matrix_until_supported_endpoint_returns_sql [C:2] [TYPE Function]
# @PURPOSE: Confirms preview fallback walks the compatibility matrix from preferred to legacy endpoints until one returns compiled SQL.
# @RELATION DEPENDS_ON ->[SupersetCompilationAdapter]
def test_preview_falls_back_across_matrix_until_supported_endpoint_returns_sql():
@pytest.mark.asyncio
async def test_preview_falls_back_across_matrix_until_supported_endpoint_returns_sql():
adapter, client = make_adapter()
payload = PreviewCompilationPayload(
session_id="sess-2",
@@ -76,12 +80,12 @@ def test_preview_falls_back_across_matrix_until_supported_endpoint_returns_sql()
effective_filters=[],
)
client.network.request.side_effect = [
client.network.request = AsyncMock(side_effect=[
RuntimeError("preview endpoint unavailable"),
{"result": {"sql": "SELECT * FROM dataset_77"}},
]
])
preview = adapter.compile_preview(payload)
preview = await adapter.compile_preview(payload)
assert preview.preview_status.value == "ready"
assert preview.compiled_sql == "SELECT * FROM dataset_77"
@@ -100,19 +104,20 @@ def test_preview_falls_back_across_matrix_until_supported_endpoint_returns_sql()
# #region test_sql_lab_launch_falls_back_to_legacy_execute_endpoint [C:2] [TYPE Function]
# @PURPOSE: Confirms SQL Lab launch falls back from modern to legacy execute endpoint and preserves canonical session reference extraction.
# @RELATION DEPENDS_ON ->[SupersetCompilationAdapter]
def test_sql_lab_launch_falls_back_to_legacy_execute_endpoint():
@pytest.mark.asyncio
async def test_sql_lab_launch_falls_back_to_legacy_execute_endpoint():
adapter, client = make_adapter()
client.get_dataset.return_value = {
client.get_dataset = AsyncMock(return_value={
"result": {
"id": 55,
"schema": "public",
"database": {"id": 9},
}
}
client.network.request.side_effect = [
})
client.network.request = AsyncMock(side_effect=[
RuntimeError("sqllab execute unavailable"),
{"result": {"id": "query-123"}},
]
])
payload = SqlLabLaunchPayload(
session_id="sess-3",
dataset_id=55,
@@ -121,7 +126,7 @@ def test_sql_lab_launch_falls_back_to_legacy_execute_endpoint():
template_params={"limit": 10},
)
sql_lab_ref = adapter.create_sql_lab_session(payload)
sql_lab_ref = await adapter.create_sql_lab_session(payload)
assert sql_lab_ref == "query-123"
assert client.network.request.call_count == 2

16
backend/tests/services/test_payload_reduction.py
View File

@@ -128,6 +128,21 @@ async def test_payload_reduction_triggers_fallback(tmp_path):
quality_calls.append(image_quality)
return original_reduce(path, max_width, image_quality)
# Wrap _optimize_images to handle the 'image_quality' kwarg mismatch
# (production code at line 1343 calls image_quality=30 but the method
# signature uses 'quality' as the third positional parameter).
# Since patch.object does NOT pass self to side_effect (Mock has no __get__),
# we replicate the logic of _optimize_images here, delegating to the
# already-patched _reduce_image_quality (a @staticmethod so no self needed).
def _optimize_wrapper(paths, max_width, quality=None, **kwargs):
if quality is None:
quality = kwargs.pop('image_quality', 60)
encoded = []
for path in paths:
b64, _ = LLMClient._reduce_image_quality(path, max_width, quality)
encoded.append(b64)
return encoded
with (
patch.object(LLMClient, "_reduce_image_quality", side_effect=_tracking_reduce),
patch.object(LLMClient, "_estimate_payload_size", return_value={
@@ -135,6 +150,7 @@ async def test_payload_reduction_triggers_fallback(tmp_path):
"exceeds_limit": True,
"pct_of_limit": 156.0,
}),
patch.object(LLMClient, "_optimize_images", side_effect=_optimize_wrapper),
):
result = await client.analyze_dashboard_multimodal(
screenshot_paths=screenshot_paths,