feat(agent-chat): 035-agent-chat-context — контекст, guardrails, tools, database discovery
== User stories == US1: Контекст с дашборда/датасета → /agent с URL params US2: Guardrails card — env badge, 7 risk tones, countdown, permission_denied US3: Tools optimization — retry, timeout, summarise, RBAC + context affinity == Backend == - _context.py (NEW): UIContext validation (7 checks) - _tool_filter.py (NEW): RBAC + context affinity pipeline - _confirmation.py: build_confirmation_contract_v2, permission_denied_payload - tools.py: superset_list_databases, retry/summarise/timeout wrappers - app.py: _inject_uicontext, _inject_env_id_into_tools, database prefetch в runtime context - _persistence.py: prefetch_databases() - agent_superset_explore.py: GET /databases endpoint - _llm_async_http.py, _persistence.py: fix double /v1 в LLM URL (LM Studio Unexpected endpoint) == Frontend == - AgentChatModel.svelte.ts: 5 atoms, 3 actions, countdown, context - AgentChat.svelte: production banner, process steps, debug panel - ConfirmationCard.svelte: 7 risk tones, permission_denied, countdown - ToolCallCard.svelte: retrying/timeout/cancelled states - StreamProcessor.svelte.ts: tool_retry, timeout, permission_denied - TopNavbar: sparkles icon + Ассистент - sidebarNavigation: AI section - DashboardHeader, datasets/+page: contextual AI buttons - Icon: sparkles, brain, cpu icons - tailwind: assistant category colors - i18n: en/ru nav keys == Tests == - 159 backend agent tests (+16 US3: retry, timeout, summarise, contracts) - 2544 frontend tests (+11 model + component tests) - 15 JSON fixtures (10 API + 5 model) == Specs == - specs/035-agent-chat-context/: spec, UX, plan, tasks, research, data-model, contracts, quickstart, traceability, fixtures, checklists Closes #035
This commit is contained in:
@@ -247,24 +247,35 @@ After all questions are answered, create TWO artifacts:
|
||||
|
||||
### Phase 7: Generate Artifacts
|
||||
|
||||
ONLY after all design decisions are made:
|
||||
ONLY after all design decisions are made.
|
||||
|
||||
**ALL artifacts go into `FEATURE_DIR/contracts/ux/`** — NEVER into `frontend/src/lib/`. The UX phase produces design contracts, not implementation. Actual source files are written by `/speckit.implement`.
|
||||
|
||||
1. **`contracts/ux/screen-models.md`** — Model inventory from Phase 1-2 decisions
|
||||
2. **`contracts/ux/api-ux.md`** — API shapes from Phase 4
|
||||
3. **`contracts/ux/<screen>-ux.md`** × N — per-screen UX contracts from Phase 2-3
|
||||
4. **`contracts/ux/design-tokens.md`** — token application from Phase 3
|
||||
5. **`frontend/src/lib/models/<Domain>Model.svelte.ts`** — generated model code
|
||||
5. **`contracts/ux/model-changes.md`** — precise edit instructions for existing models (atoms, derived, actions to add; exact file paths and line insertions). For NEW models, include the full reference model code in this file — `/speckit.implement` will translate it into the real source file.
|
||||
6. **`contracts/ux/model-<domain>.svelte.ts`** (optional) — ONLY for NEW Screen Models that don't exist yet. This is a reference copy in the spec folder — `/speckit.implement` will create the actual file in `frontend/src/lib/models/`.
|
||||
|
||||
For artifacts 3-5, use the templates defined below. Do NOT generate contracts before design decisions are recorded.
|
||||
For artifacts 3-6, use the templates defined below. Do NOT generate contracts before design decisions are recorded.
|
||||
|
||||
### Phase 8: Confirmation Gate
|
||||
|
||||
Before writing model files to `frontend/src/lib/models/`, present:
|
||||
Before writing any contract files, present:
|
||||
|
||||
| File | Path | Atoms | Actions | Dependencies |
|
||||
|------|------|-------|---------|-------------|
|
||||
| # | File | Location | Type | Summary |
|
||||
|---|------|----------|------|---------|
|
||||
| 1 | `contracts/ux/screen-models.md` | `FEATURE_DIR/contracts/ux/` | Inventory | Models touched, new atoms, component changes |
|
||||
| 2 | `contracts/ux/api-ux.md` | `FEATURE_DIR/contracts/ux/` | API shapes | Endpoints, SSE events, sequences |
|
||||
| 3 | `contracts/ux/<screen>-ux.md` | `FEATURE_DIR/contracts/ux/` | Per-screen FSM | States, feedback, recovery, UX tests |
|
||||
| 4 | `contracts/ux/design-tokens.md` | `FEATURE_DIR/contracts/ux/` | Token map | Semantic token → state mapping |
|
||||
| 5 | `contracts/ux/model-changes.md` | `FEATURE_DIR/contracts/ux/` | Edit diff | Exact additions to existing source files |
|
||||
| 6 | `contracts/ux/model-<domain>.svelte.ts` | `FEATURE_DIR/contracts/ux/` | Ref model (NEW only) | Full model code — `/speckit.implement` copies to `frontend/src/lib/models/` |
|
||||
|
||||
Ask: "Write these model files? (yes/no)"
|
||||
**Rule:** Items 1-5 are mandatory. Item 6 only when creating a NEW Screen Model that doesn't exist in `frontend/src/lib/models/`.
|
||||
|
||||
Ask: "Write these UX contracts to `FEATURE_DIR/contracts/ux/`? (yes/no)"
|
||||
|
||||
## Artifact Templates
|
||||
|
||||
@@ -297,10 +308,12 @@ idle → [trigger] → loading → [success] → loaded
|
||||
| @UX_TEST | Given | When | Then |
|
||||
```
|
||||
|
||||
### `<Domain>Model.svelte.ts` — generated code
|
||||
### `model-<domain>.svelte.ts` — reference model code (spec folder only)
|
||||
|
||||
**ONLY for NEW Screen Models.** This file lives in `FEATURE_DIR/contracts/ux/`. `/speckit.implement` will create the actual file at `frontend/src/lib/models/<Domain>Model.svelte.ts`.
|
||||
|
||||
```typescript
|
||||
// frontend/src/lib/models/<Domain>Model.svelte.ts
|
||||
// REFERENCE MODEL — will be created at frontend/src/lib/models/<Domain>Model.svelte.ts by /speckit.implement
|
||||
// #region <Domain>.Model [C:4] [TYPE Model] [SEMANTICS <domain>,<feature>,screen-model]
|
||||
// @defgroup <Domain> <One-line from decisions>.
|
||||
// @INVARIANT <from Phase 2-3 decisions>
|
||||
|
||||
Reference in New Issue
Block a user