busya
fbe0ba122c
Fixed async/sync boundary bugs across 14 test files. Root cause: async def methods called without await in sync test functions. Fixed files: - test_translate_jobs.py (10): create_job/get_job/update_job/delete_job - test_translate_scheduler.py (5): create_schedule/update/delete - test_datasets.py (14): AsyncMock + corrected patch target - test_mapping_service.py (11): sync_environment + MockSupersetClient - test_defensive_guards.py (6): GitService/SupersetClient guards - test_maintenance_service.py (29): all 6 maintenance services - test_dry_run_orchestrator.py (1): run() without await - test_dashboards_api.py (23): registry client via AsyncMock - test_validation_tasks.py (4): trailing slash in POST URL - test_superset_matrix.py (3): AsyncMock for compile_preview - test_payload_reduction.py (6): LLMClient._optimize_image wrapper - test_compliance_task_integration.py (2): event_bus ref - test_smoke_plugins.py (1): flusher_stop_event fallback - test_task_manager.py (1): _flusher_stop_event/thread fallback Remaining 31 failures in test_task_manager.py (29) and test_smoke_plugins.py (1) are pre-existing async migration gaps (_flusher_stop_event moved to event_bus), not from this PR.
89 lines
3.2 KiB
Python
89 lines
3.2 KiB
Python
import os
|
|
from pathlib import Path
|
|
import pytest
|
|
import sys
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
import tests.conftest # noqa: F401 — ensure conftest runs first
|
|
|
|
sys.path.insert(0, str(Path(__file__).parent.parent))
|
|
|
|
# ── Save original module before it gets mocked ──
|
|
_ORIG_DATABASE_MODULE = sys.modules.get('src.core.database')
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def isolate_database():
|
|
"""Isolate this test module from the real database.
|
|
|
|
Saves the real src.core.database, replaces it with a MagicMock,
|
|
and restores it after the test completes. This prevents PluginLoader
|
|
imports from triggering real database initialization.
|
|
"""
|
|
# Remove real module if loaded
|
|
sys.modules.pop('src.core.database', None)
|
|
# Insert mock
|
|
mock_db = MagicMock()
|
|
sys.modules['src.core.database'] = mock_db
|
|
yield
|
|
# Restore real module
|
|
sys.modules.pop('src.core.database', None)
|
|
if _ORIG_DATABASE_MODULE is not None:
|
|
sys.modules['src.core.database'] = _ORIG_DATABASE_MODULE
|
|
|
|
|
|
class TestPluginSmoke:
|
|
"""Smoke tests for plugin loading and initialization."""
|
|
|
|
def test_plugins_load_successfully(self):
|
|
"""
|
|
Verify that all standard plugins can be discovered and instantiated
|
|
by the PluginLoader without throwing errors (e.g., missing imports,
|
|
syntax errors, missing class declarations).
|
|
"""
|
|
from src.core.plugin_loader import PluginLoader
|
|
|
|
plugin_dir = os.path.join(str(Path(__file__).parent.parent), "src", "plugins")
|
|
|
|
# This will discover and instantiate plugins
|
|
loader = PluginLoader(plugin_dir)
|
|
|
|
plugins = loader.get_all_plugin_configs()
|
|
plugin_ids = {p.id for p in plugins}
|
|
|
|
# We expect at least the migration and git plugins to be present
|
|
expected_plugins = {"superset-migration", "git-integration"}
|
|
|
|
missing_plugins = expected_plugins - plugin_ids
|
|
assert not missing_plugins, f"Missing expected plugins: {missing_plugins}"
|
|
|
|
@pytest.mark.anyio
|
|
async def test_task_manager_initializes_with_plugins(self):
|
|
"""
|
|
Verify that the TaskManager can initialize with the real PluginLoader.
|
|
"""
|
|
from src.core.plugin_loader import PluginLoader
|
|
from src.core.task_manager.manager import TaskManager
|
|
|
|
plugin_dir = os.path.join(str(Path(__file__).parent.parent), "src", "plugins")
|
|
loader = PluginLoader(plugin_dir)
|
|
|
|
# Initialize TaskManager with real loader
|
|
with patch("src.core.task_manager.manager.TaskPersistenceService") as MockPersistence, \
|
|
patch("src.core.task_manager.manager.TaskLogPersistenceService"):
|
|
|
|
MockPersistence.return_value.load_tasks.return_value = []
|
|
|
|
with patch("src.dependencies.config_manager"):
|
|
manager = TaskManager(loader)
|
|
|
|
# Stop the flusher thread to prevent hanging
|
|
if hasattr(manager, '_flusher_stop_event'):
|
|
manager._flusher_stop_event.set()
|
|
elif hasattr(manager, 'event_bus') and hasattr(manager.event_bus, '_flusher_stop_event'):
|
|
manager.event_bus._flusher_stop_event.set()
|
|
if hasattr(manager, '_flusher_thread'):
|
|
manager._flusher_thread.join(timeout=2)
|
|
|
|
assert manager is not None
|