busya/ss-tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity
Files
master
ss-tools/docs/adr/ADR-0018-rejected-dataset-review.md
busya 585a00c537 semantic-curation: fix anchors, metadata, and relations across backend + specs 
- Replace legacy @PURPOSE with @BRIEF across 241 files
- Add missing [C:N] complexity tiers to function contracts in core modules
- Fix tombstone contracts: add @STATUS DEPRECATED to 5 deprecated anchors
- Resolve 7 unresolved @RELATION edges in executor.py (DictionaryManager, TranslationPreview, etc.)
- Fix flat hierarchical IDs in 4 test files (22 test functions)
- Fix invalid tags/relations in logger.py (@ADR, @CONSEQUENCES, DISABLED_BY)
- Rebuild semantic index: 9,576 contracts, 4,742 edges, 0 parse warnings
2026-08-20 11:45:15 +03:00

3.5 KiB
Raw Permalink Blame History

[DEF:Doc.Adr.ADR0018:ADR]

@STATUS REJECTED

@BRIEF Record the permanent rejection of the Dataset Review feature and prohibit restoring its workflow, UI, APIs, session model, or assistant commands without a replacement ADR.

@RELATION DEPENDS_ON -> [Doc.Adr.ADR0006]

@RELATION DEPENDS_ON -> [Doc.Adr.ADR0008]

@RATIONALE Dataset Review was a cross-cutting orchestration proposal spanning persistent review sessions, semantic enrichment, guided assistant interaction, SQL preview, and SQL Lab launch. Its large coupled surface would preserve unsupported product behavior and maintenance obligations after the feature has been removed from the active product.

@RATIONALE The existing specs/027-dataset-llm-orchestration/ artifacts remain useful as historical design evidence. They are retained in place and explicitly deactivated rather than deleted, so prior decisions and scope can be audited without implying that the feature is active.

@REJECTED Restoring Dataset Review from its retained spec, routes, components, APIs, stores, session entities, or assistant commands without a new ADR and a newly accepted specification - rejected because the retained materials are historical only and do not authorize implementation.

@REJECTED Maintaining partial Dataset Review inventory entries in active architecture ADRs - rejected because stale inventories falsely advertise removed modules and routes as supported architecture.

ADR-0018: REJECTED - Dataset Review

Status

REJECTED - Dataset Review is not an active product capability. This ADR is the durable decision record for the rejected feature and supersedes any implication in historical feature materials that delivery remains planned or accepted.

Context

specs/027-dataset-llm-orchestration/ describes a proposed Dataset Review workflow. The workflow was removed from the active product. Its specification and supporting artifacts contain useful historical scope, but they must not be used as implementation authority or as evidence of a current UI, route, backend API, data model, or assistant integration.

Active architecture inventories previously listed Dataset Review modules and routes. Those entries are inaccurate after the rejection and are removed by this decision.

Decision

  1. Dataset Review is rejected and MUST NOT be restored or extended from specs/027-dataset-llm-orchestration/.
  2. The 027 artifacts remain in their existing location as a minimally disruptive historical record. ARCHIVED.md, spec.md, plan.md, and tasks.md identify their inactive status and link to this ADR.
  3. Active ADR inventories MUST NOT list Dataset Review components, stores, routes, or assistant modules as current architecture.
  4. A future Dataset Review proposal requires a new ADR and a newly accepted specification; it must not reactivate the archived materials by implication.

Consequences

Positive

  • The rejected scope remains auditable without preserving it as a product commitment.
  • Active architecture documentation matches the product surface.
  • Future work has an explicit decision boundary and cannot accidentally revive the removed workflow.

Negative

  • Historical 027 artifacts may describe interfaces and behavior that no longer exist.
  • Any future dataset orchestration work starts with a new decision and spec rather than continuing the archived plan.

References

  • specs/027-dataset-llm-orchestration/ARCHIVED.md
  • specs/027-dataset-llm-orchestration/spec.md
  • ADR-0006 - Frontend Architecture
  • ADR-0008 - Assistant Tool Registry

[/DEF:Doc.Adr.ADR0018:ADR]